Jelajahi Sumber

@uppy/robodog,@uppy/transloadit: use modern syntax to simplify code (#3873)

Antoine du Hamel 2 tahun lalu
induk
melakukan
f36c732e73

+ 4 - 9
packages/@uppy/robodog/src/TransloaditFormResult.js

@@ -17,17 +17,12 @@ class TransloaditFormResult extends BasePlugin {
   }
 
   getAssemblyStatuses (fileIDs) {
-    const assemblyIds = []
-    fileIDs.forEach((fileID) => {
-      const file = this.uppy.getFile(fileID)
-      const assembly = file.transloadit && file.transloadit.assembly
-      if (assembly && assemblyIds.indexOf(assembly) === -1) {
-        assemblyIds.push(assembly)
-      }
-    })
+    const assemblyIds = new Set(
+      fileIDs.map(fileID => this.uppy.getFile(fileID)?.transloadit?.assembly).filter(Boolean),
+    )
 
     const tl = this.uppy.getPlugin(this.opts.transloaditPluginId || 'Transloadit')
-    return assemblyIds.map((id) => tl.getAssembly(id))
+    return Array.from(assemblyIds, (id) => tl.getAssembly(id))
   }
 
   handleUpload (fileIDs) {

+ 2 - 2
packages/@uppy/transloadit/src/index.js

@@ -300,7 +300,7 @@ export default class Transloadit extends BasePlugin {
    */
   #onFileUploadURLAvailable = (rawFile) => {
     const file = this.uppy.getFile(rawFile.id)
-    if (!file || !file.transloadit || !file.transloadit.assembly) {
+    if (!file?.transloadit?.assembly) {
       return
     }
 
@@ -829,7 +829,7 @@ export default class Transloadit extends BasePlugin {
 
   getAssemblyFiles (assemblyID) {
     return this.uppy.getFiles().filter((file) => {
-      return file && file.transloadit && file.transloadit.assembly === assemblyID
+      return file?.transloadit?.assembly === assemblyID
     })
   }
 }