meta: disable `@typescript-eslint/no-empty-function` lint rule (#4891)

.eslintrc.js

@@ -462,6 +462,7 @@ module.exports = {
       ],
       rules: {
         'import/prefer-default-export': 'off',
+        '@typescript-eslint/no-empty-function': 'off',
         '@typescript-eslint/no-explicit-any': 'off',
         '@typescript-eslint/no-extra-semi': 'off',
         '@typescript-eslint/no-namespace': 'off',

packages/@uppy/audio/src/audio-oscilloscope/index.ts

@@ -76,10 +76,7 @@ export default class AudioOscilloscope {
       result(canvasContextOptions.strokeStyle) || 'rgb(0, 0, 0)'
     this.canvasContext.lineWidth = result(canvasContextOptions.lineWidth) || 1
     this.onDrawFrame =
-      isFunction(options.onDrawFrame) ?
-        options.onDrawFrame
-        // eslint-disable-next-line @typescript-eslint/no-empty-function
-      : () => {}
+      isFunction(options.onDrawFrame) ? options.onDrawFrame : () => {}
   }
 
   addSource(streamSource: MediaStreamAudioSourceNode): void {

packages/@uppy/core/src/BasePlugin.ts

@@ -1,5 +1,4 @@
 /* eslint-disable class-methods-use-this */
-/* eslint-disable @typescript-eslint/no-empty-function */
 
 /**
  * Core plugin logic that all plugins share.

packages/@uppy/core/src/UIPlugin.ts

@@ -1,5 +1,4 @@
 /* eslint-disable class-methods-use-this */
-/* eslint-disable @typescript-eslint/no-empty-function */
 import { render, type ComponentChild } from 'preact'
 import findDOMElement from '@uppy/utils/lib/findDOMElement'
 import getTextDirection from '@uppy/utils/lib/getTextDirection'

packages/@uppy/core/src/Uppy.test.ts

@@ -611,7 +611,6 @@ describe('src/Core', () => {
   describe('preprocessors', () => {
     it('should add and remove preprocessor', () => {
       const core = new Core()
-      // eslint-disable-next-line @typescript-eslint/no-empty-function
       const preprocessor = () => {}
       expect(core.removePreProcessor(preprocessor)).toBe(false)
       core.addPreProcessor(preprocessor)
@@ -731,7 +730,6 @@ describe('src/Core', () => {
   describe('postprocessors', () => {
     it('should add and remove postprocessor', () => {
       const core = new Core()
-      // eslint-disable-next-line @typescript-eslint/no-empty-function
       const postprocessor = () => {}
       expect(core.removePostProcessor(postprocessor)).toBe(false)
       core.addPostProcessor(postprocessor)
@@ -849,7 +847,6 @@ describe('src/Core', () => {
   describe('uploaders', () => {
     it('should add and remove uploader', () => {
       const core = new Core()
-      // eslint-disable-next-line @typescript-eslint/no-empty-function
       const uploader = () => {}
       expect(core.removeUploader(uploader)).toBe(false)
       core.addUploader(uploader)

packages/@uppy/core/src/loggers.ts

@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/no-empty-function */
 /* eslint-disable no-console */
 import getTimeStamp from '@uppy/utils/lib/getTimeStamp'
 

packages/@uppy/core/types/index.test-d.ts

@@ -80,7 +80,6 @@ type anyObject = Record<string, unknown>
 {
   // Meta signature
   type Meta = { myCustomMetadata: string }
-  /* eslint-disable @typescript-eslint/no-empty-function */
   const uppy = new Uppy<Meta>()
   // can emit events with internal event types
   uppy.emit('upload')
@@ -97,7 +96,6 @@ type anyObject = Record<string, unknown>
   uppy.once('upload', () => {})
   uppy.once('complete', () => {})
   uppy.once('error', () => {})
-  /* eslint-enable @typescript-eslint/no-empty-function */
 
   // Normal event signature
   uppy.on('complete', (result) => {