Преглед на файлове

companion: delete tus error's originalRequest field before propagatin… (#2733)

Ifedapo .A. Olarewaju преди 4 години
родител
ревизия
e24430cc1c
променени са 1 файла, в които са добавени 8 реда и са изтрити 0 реда
  1. 8 0
      packages/@uppy/companion/src/server/Uploader.js

+ 8 - 0
packages/@uppy/companion/src/server/Uploader.js

@@ -436,6 +436,14 @@ class Uploader {
        */
       onError (error) {
         logger.error(error, 'uploader.tus.error')
+        // deleting tus originalRequest field because it uses the same http-agent
+        // as companion, and this agent may contain sensitive request details (e.g headers)
+        // previously made to providers. Deleting the field would prevent it from getting leaked
+        // to the frontend etc.
+        // @ts-ignore
+        delete error.originalRequest
+        // @ts-ignore
+        delete error.originalResponse
         uploader.emitError(error)
       },
       /**