Prechádzať zdrojové kódy

@uppy/aws-s3: make passing `signal` consistent (#5200)

Mikael Finstad 11 mesiacov pred
rodič
commit
b7b03cb453

+ 1 - 1
examples/aws-nodejs/public/index.html

@@ -154,7 +154,7 @@
               return data
               return data
             },
             },
 
 
-            async abortMultipartUpload(file, { key, uploadId }, signal) {
+            async abortMultipartUpload(file, { key, uploadId, signal }) {
               const filename = encodeURIComponent(key)
               const filename = encodeURIComponent(key)
               const uploadIdEnc = encodeURIComponent(uploadId)
               const uploadIdEnc = encodeURIComponent(uploadId)
               const response = await fetch(
               const response = await fetch(

+ 0 - 2
packages/@uppy/aws-s3/src/index.ts

@@ -574,9 +574,7 @@ export default class AwsS3Multipart<
     file: UppyFile<M, B>,
     file: UppyFile<M, B>,
     { key, uploadId, signal }: UploadResultWithSignal,
     { key, uploadId, signal }: UploadResultWithSignal,
     // eslint-disable-next-line @typescript-eslint/no-unused-vars
     // eslint-disable-next-line @typescript-eslint/no-unused-vars
-    oldSignal?: AbortSignal, // TODO: remove in next major
   ): Promise<void> {
   ): Promise<void> {
-    signal ??= oldSignal // eslint-disable-line no-param-reassign
     this.assertHost('abortMultipartUpload')
     this.assertHost('abortMultipartUpload')
 
 
     const filename = encodeURIComponent(key)
     const filename = encodeURIComponent(key)