Ver Fonte

meta: use default argument value instead of `defaultProps` (#5222)

Antoine du Hamel há 10 meses atrás
pai
commit
b58fc5569e
2 ficheiros alterados com 36 adições e 46 exclusões
  1. 5 1
      .eslintrc.js
  2. 31 45
      packages/@uppy/status-bar/src/StatusBarUI.tsx

+ 5 - 1
.eslintrc.js

@@ -91,9 +91,13 @@ module.exports = {
     'react/no-this-in-sfc': 'error',
     'react/no-will-update-set-state': 'error',
     'react/prefer-stateless-function': 'error',
+    'react/require-default-props': ['error', {
+      forbidDefaultForRequired: true,
+      functions: 'defaultArguments',
+    }],
     'react/sort-comp': 'error',
-    'react/style-prop-object': 'error',
     'react/static-property-placement': 'off',
+    'react/style-prop-object': 'error',
 
     // accessibility
     'jsx-a11y/alt-text': 'error',

+ 31 - 45
packages/@uppy/status-bar/src/StatusBarUI.tsx

@@ -59,41 +59,37 @@ export interface StatusBarUIProps<M extends Meta, B extends Body> {
   totalUploadedSize: number
 }
 
-export default function StatusBarUI<M extends Meta, B extends Body>(
-  props: StatusBarUIProps<M, B>,
-) {
-  const {
-    newFiles,
-    allowNewUpload,
-    isUploadInProgress,
-    isAllPaused,
-    resumableUploads,
-    error,
-    hideUploadButton,
-    hidePauseResumeButton,
-    hideCancelButton,
-    hideRetryButton,
-    recoveredState,
-    uploadState,
-    totalProgress,
-    files,
-    supportsUploadProgress,
-    hideAfterFinish,
-    isSomeGhost,
-    doneButtonHandler,
-    isUploadStarted,
-    i18n,
-    startUpload,
-    uppy,
-    isAllComplete,
-    showProgressDetails,
-    numUploads,
-    complete,
-    totalSize,
-    totalETA,
-    totalUploadedSize,
-  } = props
-
+export default function StatusBarUI<M extends Meta, B extends Body>({
+  newFiles,
+  allowNewUpload,
+  isUploadInProgress,
+  isAllPaused,
+  resumableUploads,
+  error,
+  hideUploadButton = undefined,
+  hidePauseResumeButton = false,
+  hideCancelButton = false,
+  hideRetryButton = false,
+  recoveredState,
+  uploadState,
+  totalProgress,
+  files,
+  supportsUploadProgress,
+  hideAfterFinish = false,
+  isSomeGhost,
+  doneButtonHandler = undefined,
+  isUploadStarted,
+  i18n,
+  startUpload,
+  uppy,
+  isAllComplete,
+  showProgressDetails = undefined,
+  numUploads,
+  complete,
+  totalSize,
+  totalETA,
+  totalUploadedSize,
+}: StatusBarUIProps<M, B>) {
   function getProgressValue(): number | null {
     switch (uploadState) {
       case STATE_POSTPROCESSING:
@@ -285,13 +281,3 @@ export default function StatusBarUI<M extends Meta, B extends Body>(
     </div>
   )
 }
-
-StatusBarUI.defaultProps = {
-  doneButtonHandler: undefined,
-  hideAfterFinish: false,
-  hideCancelButton: false,
-  hidePauseResumeButton: false,
-  hideRetryButton: false,
-  hideUploadButton: undefined,
-  showProgressDetails: undefined,
-}