Parcourir la source

Style the table with classes.

Renée Kooi il y a 6 ans
Parent
commit
aa14ac4ba8
2 fichiers modifiés avec 19 ajouts et 57 suppressions
  1. 9 14
      website/themes/uppy/layout/stats.ejs
  2. 10 43
      website/themes/uppy/source/css/_stats.scss

+ 9 - 14
website/themes/uppy/layout/stats.ejs

@@ -24,30 +24,25 @@
   <p>
     Below are the minified and gzipped sizes for each Uppy package. Note that this includes the dependencies for each package, some of which are shared when you install multiple plugins—for example, the `@uppy/dropbox` and `@uppy/instagram` package are both over 11kB including dependencies, but only sum up to about 15kB when they are used together.
   </p>
-  <table width="100%">
+  <table class="Stats-bundleSizes">
     <thead>
       <tr>
-        <th align="left">Package</th>
-        <th align="left">Minified</th>
-        <th align="left">Gzip</th>
+        <th class="Stats-bundleSizeHeader">Package</th>
+        <th class="Stats-bundleSizeHeader">Minified</th>
+        <th class="Stats-bundleSizeHeader">Gzip</th>
       </tr>
     </thead>
     <tbody>
       <% for (const [name, sizes] of Object.entries(theme.uppy_bundle_kb_sizes)) { %>
         <% const { minified, gzipped, prettyMinified, prettyGzipped } = sizes %>
         <tr>
-          <td><%- name %></td>
+          <td><a class="Stats-package" target="_blank" href="https://npmjs.com/package/<%= name %>"><%= name %></a></td>
+          <td><%= prettyMinified %></td>
           <td class="
-            <% if (minified > 50 * 1000) { %>red<% } %>
-            <% if (minified < 20 * 1000) { %>green<% } %>
+            <% if (gzipped > 30 * 1000) { %>Stats-large<% } %>
+            <% if (gzipped < 10 * 1000) { %>Stats-small<% } %>
           ">
-            <%- prettyMinified %>
-          </td>
-          <td class="
-            <% if (gzipped > 30 * 1000) { %>red<% } %>
-            <% if (gzipped < 10 * 1000) { %>green<% } %>
-          ">
-            <%- prettyGzipped %>
+            <%= prettyGzipped %>
           </td>
         </tr>
       <% } %>

+ 10 - 43
website/themes/uppy/source/css/_stats.scss

@@ -11,52 +11,19 @@
 
 .Stats-bundleSizes {
   margin-bottom: 1em;
+  width: 100%;
 
-  @media #{$screen-large} {
-    max-width: 320px;
-    float: right;
-    margin-right: -320px;
-    padding-left: 50px;
-  }
+  th { text-align: left; }
 }
 
-.Stats-bundleSizes {
-  strong.underline {
-    display: inline-block;
-    border-bottom: 1px solid #eee;
-    margin-bottom: 5px;
-  }
-
-  dl {
-    @include clearfix;
-    width: 100%;
-    padding: 0;
-    margin: 0;
-    line-height: 1.5;
-  }
-
-  dt {
-    float: left;
-    width: 50%;
-    padding: 0;
-    margin: 0;
-    a {
-      color: #e02177;
-    }
-  }
-
-  dd {
-    float: left;
-    width: 50%;
-    padding: 0;
-    margin: 0;
-    &.red {
-      color: red;
-    }
-    &.green {
-      color: #3FC33F;
-    }
-  }
+a.Stats-package {
+  color: #e02177;
+}
+.Stats-large {
+  color: red;
+}
+.Stats-small {
+  color: #3FC33F;
 }
 
 .Disc {