Browse Source

@uppy/companion: fix infinite recursion in uploader test (#4536)

* fix stack size exceeded

* remove invalid assertion

success event never seems to have included "bytesTotal" in payload
this assertion was mistakenly moved from onProgress to success in 
1b5c0d7d4b6ac2f387ac5699d587e281f6579afe.
Mikael Finstad 1 year ago
parent
commit
a78679a810
1 changed files with 4 additions and 4 deletions
  1. 4 4
      packages/@uppy/companion/test/__tests__/uploader.js

+ 4 - 4
packages/@uppy/companion/test/__tests__/uploader.js

@@ -118,6 +118,7 @@ describe('uploader with tus protocol', () => {
     }
 
     const uploader = new Uploader(opts)
+    const originalTryDeleteTmpPath = uploader.tryDeleteTmpPath.bind(uploader)
     uploader.tryDeleteTmpPath = async () => {
       // validate that the tmp file has been downloaded and saved into the file path
       // must do it before it gets deleted
@@ -125,7 +126,7 @@ describe('uploader with tus protocol', () => {
       expect(fileInfo.isFile()).toBe(true)
       expect(fileInfo.size).toBe(fileContent.length)
 
-      return uploader.tryDeleteTmpPath()
+      return originalTryDeleteTmpPath()
     }
     const uploadToken = uploader.token
     expect(uploadToken).toBeTruthy()
@@ -148,13 +149,12 @@ describe('uploader with tus protocol', () => {
       // emulate socket connection
       socketClient.connect(uploadToken)
       socketClient.onProgress(uploadToken, (message) => {
-        if (firstReceivedProgress == null) firstReceivedProgress = message.payload.bytesUploaded
+        if (firstReceivedProgress == null) firstReceivedProgress = message.payload
       })
       socketClient.onUploadSuccess(uploadToken, (message) => {
         try {
-          expect(message.payload.bytesTotal).toBe(fileContent.length)
+          expect(firstReceivedProgress.bytesUploaded).toBe(8192)
 
-          expect(firstReceivedProgress).toBe(8192)
           // see __mocks__/tus-js-client.js
           expect(message.payload.url).toBe('https://tus.endpoint/files/foo-bar')
         } catch (err) {