浏览代码

Fix Modal and Plugin targets and types

Artur Paikin 9 年之前
父节点
当前提交
7f24bc9e63
共有 2 个文件被更改,包括 2 次插入7 次删除
  1. 1 5
      src/plugins/Modal.js
  2. 1 2
      src/plugins/Plugin.js

+ 1 - 5
src/plugins/Modal.js

@@ -20,17 +20,13 @@ export default class Modal extends Plugin {
     // merge default options with the ones set by user
     this.opts = Object.assign({}, defaultOptions, opts)
 
-    this.targets = {}
-
-    this.targets.spinner = '.UppyDragDrop-One-Spinner'
-
     this.container = document.body
   }
 
   prepareTarget (callerPlugin) {
     console.log(callerPlugin.type)
 
-    if (callerPlugin.type !== 'selecter' || callerPlugin.type !== 'progress') {
+    if (callerPlugin.type !== 'selecter' && callerPlugin.type !== 'progress') {
       this.core.log('Error: Modal can only be used by plugins of type `selecter` or `progress`')
       return
     }

+ 1 - 2
src/plugins/Plugin.js

@@ -51,9 +51,8 @@ export default class Plugin {
       this.core.log('plugin is a target')
 
       let targetPlugin = this.core.getPlugin(target.name)
-      targetPlugin.prepareTarget(callerPlugin)
 
-      return targetPlugin
+      return targetPlugin.prepareTarget(callerPlugin)
     }
   }