소스 검색

Add todo comments

Murderlon 3 년 전
부모
커밋
79fed01a93
2개의 변경된 파일4개의 추가작업 그리고 0개의 파일을 삭제
  1. 2 0
      packages/@uppy/companion/src/standalone/helper.js
  2. 2 0
      packages/@uppy/core/src/BasePlugin.js

+ 2 - 0
packages/@uppy/companion/src/standalone/helper.js

@@ -64,12 +64,14 @@ const getConfigFromEnv = () => {
         verificationToken: getSecret('COMPANION_ZOOM_VERIFICATION_TOKEN'),
         credentialsURL: process.env.COMPANION_ZOOM_KEYS_ENDPOINT,
       },
+      // TODO: remove the redundant searchProviders warpper in next major version
       searchProviders: {
         unsplash: {
           key: process.env.COMPANION_UNSPLASH_KEY,
           secret: process.env.COMPANION_UNSPLASH_SECRET,
         },
       },
+      // TODO: move s3 out of providerOptions, it's a destination, not a source
       s3: {
         key: process.env.COMPANION_AWS_KEY,
         secret: getSecret('COMPANION_AWS_SECRET'),

+ 2 - 0
packages/@uppy/core/src/BasePlugin.js

@@ -75,6 +75,8 @@ module.exports = class BasePlugin {
     throw new Error('Extend the render method to add your plugin to a DOM element')
   }
 
+  // TODO: remove in the next major version. It's not feasible to
+  // try to use plugins with other frameworks.
   // eslint-disable-next-line class-methods-use-this
   update () {}