Преглед изворни кода

companion: remove incorrect `Expires` option (#2746)

I assumed `Expires` had to do with signed URL expiration, but in the
case of `createMultipartUpload`, it affects the _uploaded file itself_.

Those files are not automatically removed but no longer cacheable after
the expiration time, which is still bad.

Thanks to @Dock1100 for raising this! Fixes #2483.
Renée Kooi пре 4 година
родитељ
комит
72bef8d9d7
1 измењених фајлова са 1 додато и 2 уклоњено
  1. 1 2
      packages/@uppy/companion/src/server/controllers/s3.js

+ 1 - 2
packages/@uppy/companion/src/server/controllers/s3.js

@@ -92,8 +92,7 @@ module.exports = function s3 (config) {
       Key: key,
       ACL: config.acl,
       ContentType: type,
-      Metadata: metadata,
-      Expires: config.expires
+      Metadata: metadata
     }, (err, data) => {
       if (err) {
         next(err)