Browse Source

add event listeners to input elements instead

Artur Paikin 7 years ago
parent
commit
6731b82905
2 changed files with 20 additions and 16 deletions
  1. 20 15
      src/plugins/Dashboard/FileCard.js
  2. 0 1
      src/plugins/Dashboard/index.js

+ 20 - 15
src/plugins/Dashboard/FileCard.js

@@ -3,25 +3,30 @@ const getFileTypeIcon = require('./getFileTypeIcon')
 const onload = require('on-load')
 const onload = require('on-load')
 const { checkIcon } = require('./icons')
 const { checkIcon } = require('./icons')
 
 
-let file
-const meta = {}
+// let file
+// const meta = {}
 
 
 module.exports = function fileCard (props) {
 module.exports = function fileCard (props) {
-  file = props.fileCardFor ? props.files[props.fileCardFor] : false
+  const file = props.fileCardFor ? props.files[props.fileCardFor] : false
+  const meta = {}
 
 
-  const handleEnterKey = (ev) => {
-    if (file && event.keyCode === 13) {
+  // const handleEnterKey = (ev) => {
+  //   if (event.keyCode === 13) {
+  //     props.done(meta, file.id)
+  //   }
+  // }
+
+  // if (file) {
+  //   document.body.addEventListener('keyup', handleEnterKey)
+  // } else {
+  //   document.body.removeEventListener('keyup', handleEnterKey)
+  // }
+
+  const tempStoreMetaOrSubmit = (ev) => {
+    if (ev.keyCode === 13) {
       props.done(meta, file.id)
       props.done(meta, file.id)
     }
     }
-  }
-
-  if (file) {
-    document.body.addEventListener('keyup', handleEnterKey)
-  } else {
-    document.body.removeEventListener('keyup', handleEnterKey)
-  }
 
 
-  const tempStoreMeta = (ev) => {
     const value = ev.target.value
     const value = ev.target.value
     const name = ev.target.dataset.name
     const name = ev.target.dataset.name
     meta[name] = value
     meta[name] = value
@@ -37,7 +42,7 @@ module.exports = function fileCard (props) {
                data-name="${field.id}"
                data-name="${field.id}"
                value="${file.meta[field.id]}"
                value="${file.meta[field.id]}"
                placeholder="${field.placeholder || ''}"
                placeholder="${field.placeholder || ''}"
-               onkeyup=${tempStoreMeta} /></fieldset>`
+               onkeyup=${tempStoreMetaOrSubmit} /></fieldset>`
     })
     })
   }
   }
 
 
@@ -62,7 +67,7 @@ module.exports = function fileCard (props) {
             <fieldset class="UppyDashboardFileCard-fieldset">
             <fieldset class="UppyDashboardFileCard-fieldset">
               <label class="UppyDashboardFileCard-label">Name</label>
               <label class="UppyDashboardFileCard-label">Name</label>
               <input class="UppyDashboardFileCard-input" data-name="name" type="text" value="${file.meta.name}"
               <input class="UppyDashboardFileCard-input" data-name="name" type="text" value="${file.meta.name}"
-                     onkeyup=${tempStoreMeta} />
+                     onkeyup=${tempStoreMetaOrSubmit} />
             </fieldset>
             </fieldset>
             ${renderMetaFields(file)}
             ${renderMetaFields(file)}
           </div>
           </div>

+ 0 - 1
src/plugins/Dashboard/index.js

@@ -339,7 +339,6 @@ module.exports = class DashboardUI extends Plugin {
     }
     }
 
 
     const fileCardDone = (meta, fileID) => {
     const fileCardDone = (meta, fileID) => {
-      console.log(meta)
       this.core.emit('core:update-meta', meta, fileID)
       this.core.emit('core:update-meta', meta, fileID)
       this.core.emit('dashboard:file-card')
       this.core.emit('dashboard:file-card')
     }
     }