@uppy/core: remove `'upload-started'` event (#5200)

packages/@uppy/core/src/EventManager.ts

@@ -1,10 +1,5 @@
 import type { Meta, Body, UppyFile } from '@uppy/utils/lib/UppyFile'
-import type {
-  DeprecatedUppyEventMap,
-  Uppy,
-  UppyEventMap,
-  _UppyEventMap,
-} from './Uppy.js'
+import type { Uppy, UppyEventMap, _UppyEventMap } from './Uppy.js'
 
 /**
  * Create a wrapper around an event emitter with a `remove` method to remove
@@ -24,12 +19,6 @@ export default class EventManager<M extends Meta, B extends Body> {
     fn: _UppyEventMap<M, B>[K],
   ): Uppy<M, B>
 
-  /** @deprecated */
-  on<K extends keyof DeprecatedUppyEventMap<M, B>>(
-    event: K,
-    fn: DeprecatedUppyEventMap<M, B>[K],
-  ): Uppy<M, B>
-
   on<K extends keyof UppyEventMap<M, B>>(
     event: K,
     fn: UppyEventMap<M, B>[K],

packages/@uppy/core/src/Uppy.test.ts

@@ -1766,10 +1766,7 @@ describe('src/Core', () => {
 
       const uploadPromise = core.upload()
       await Promise.all([
-        // @ts-ignore deprecated
         new Promise((resolve) => core.once('upload-start', resolve)),
-        // todo backward compat: remove in next major
-        new Promise((resolve) => core.once('upload-started', resolve)),
       ])
 
       expect(core.getFiles()[0].size).toBeNull()

packages/@uppy/core/src/Uppy.ts

@@ -295,16 +295,11 @@ export interface _UppyEventMap<M extends Meta, B extends Body> {
   ) => void
 }
 
-/** @deprecated */
-export interface DeprecatedUppyEventMap<M extends Meta, B extends Body> {
+export interface UppyEventMap<M extends Meta, B extends Body>
+  extends _UppyEventMap<M, B> {
   'upload-start': (files: UppyFile<M, B>[]) => void
-  'upload-started': (file: UppyFile<M, B>) => void
 }
 
-export interface UppyEventMap<M extends Meta, B extends Body>
-  extends _UppyEventMap<M, B>,
-    DeprecatedUppyEventMap<M, B> {}
-
 const defaultUploadState = {
   totalProgress: 0,
   allowNewUpload: true,
@@ -1538,13 +1533,7 @@ export class Uppy<M extends Meta, B extends Body> {
       this.patchFilesState(filesState)
     }
 
-    this.on('upload-start', (files) => {
-      files.forEach((file: UppyFile<M, B>) => {
-        // todo backward compat, remove this event in a next major
-        this.emit('upload-started', file)
-      })
-      onUploadStarted(files)
-    })
+    this.on('upload-start', onUploadStarted)
 
     this.on('upload-progress', this.calculateProgress)