Quellcode durchsuchen

add aria-hidden to icon, use i18n for aria-labels and title

Artur Paikin vor 6 Jahren
Ursprung
Commit
2f2561a322
2 geänderte Dateien mit 8 neuen und 4 gelöschten Zeilen
  1. 3 1
      packages/@uppy/core/src/index.js
  2. 5 3
      packages/@uppy/provider-views/src/Filter.js

+ 3 - 1
packages/@uppy/core/src/index.js

@@ -46,7 +46,9 @@ class Uppy {
           1: 'Select %{smart_count} files'
         },
         cancel: 'Cancel',
-        logOut: 'Log out'
+        logOut: 'Log out',
+        filter: 'Filter',
+        resetFilter: 'Reset filter'
       }
     }
 

+ 5 - 3
packages/@uppy/provider-views/src/Filter.js

@@ -23,8 +23,8 @@ module.exports = class Filter extends Component {
       <input
         class="uppy-u-reset uppy-ProviderBrowser-searchInput"
         type="text"
-        placeholder="Filter"
-        aria-label="Filter"
+        placeholder={this.props.i18n('filter')}
+        aria-label={this.props.i18n('filter')}
         onkeyup={this.handleKeyPress}
         onkeydown={this.handleKeyPress}
         onkeypress={this.handleKeyPress}
@@ -34,8 +34,10 @@ module.exports = class Filter extends Component {
         <button
           class="uppy-u-reset uppy-ProviderBrowser-searchClose"
           type="button"
+          aria-label={this.props.i18n('resetFilter')}
+          title={this.props.i18n('resetFilter')}
           onclick={this.props.filterQuery}>
-          <svg class="UppyIcon" viewBox="0 0 19 19">
+          <svg aria-hidden="true" class="UppyIcon" viewBox="0 0 19 19">
             <path d="M17.318 17.232L9.94 9.854 9.586 9.5l-.354.354-7.378 7.378h.707l-.62-.62v.706L9.318 9.94l.354-.354-.354-.354L1.94 1.854v.707l.62-.62h-.706l7.378 7.378.354.354.354-.354 7.378-7.378h-.707l.622.62v-.706L9.854 9.232l-.354.354.354.354 7.378 7.378.708-.707-7.38-7.378v.708l7.38-7.38.353-.353-.353-.353-.622-.622-.353-.353-.354.352-7.378 7.38h.708L2.56 1.23 2.208.88l-.353.353-.622.62-.353.355.352.353 7.38 7.38v-.708l-7.38 7.38-.353.353.352.353.622.622.353.353.354-.353 7.38-7.38h-.708l7.38 7.38z" />
           </svg>
         </button>