Browse Source

improve open graph descriptions and titles, move GA to the bottom to speed up the website

Artur Paikin 8 years ago
parent
commit
0c37ac9c9a
2 changed files with 19 additions and 12 deletions
  1. 13 12
      website/themes/uppy/layout/layout.ejs
  2. 6 0
      website/themes/uppy/source/css/_common.scss

+ 13 - 12
website/themes/uppy/layout/layout.ejs

@@ -1,22 +1,23 @@
 <% var isIndex = page.path === 'index.html' %>
+<% var title = page.title ? page.title + ' - ' + config.title : config.title %>
+<% var excerpt = page.excerpt ? page.excerpt.replace(/(<([^>]+)>)/ig, '') : config.description %>
 <!DOCTYPE html>
 <html lang="en">
   <head>
-    <title><%- page.title ? page.title + ' - ' : '' %><%= config.title %></title>
+    <title><%- title %></title>
     <meta charset="utf-8">
-    <meta name="title" content="<%= config.title %>">
-    <meta name="description" content="<%= config.subtitle %>">
+    <meta name="title" content="<%= title %>">
+    <meta name="description" content="<%= excerpt %>">
     <meta name="viewport" content="width=device-width, initial-scale=1">
     <meta name="twitter:card" content="summary_large_image">
     <meta name="twitter:site" content="@uppy_io">
     <meta name="twitter:creator" content="@uppy_io">
     <meta property="og:url" content="<%- url %>">
-    <meta property="og:title" content="<%- page.title ? page.title + ' - ' : '' %><%= config.title %>">
-    <meta name="twitter:title" content="<%- page.title ? page.title + ' - ' : '' %><%= config.title %>">
-    <meta name="description" content="<%= page.excerpt ? page.excerpt : config.description %>">
-    <meta name="twitter:description" content="<%= config.description %>">
-    <meta property="og:image" content="/images/uppy-social.jpg">
-    <meta name="twitter:image" content="/images/uppy-social.jpg">
+    <meta property="og:title" content="<%- title %>">
+    <meta name="twitter:title" content="<%- title %>">
+    <meta name="twitter:description" content="<%- excerpt %>">
+    <meta property="og:image" content="http://uppy.io/images/uppy-social.jpg">
+    <meta name="twitter:image" content="http://uppy.io/images/uppy-social.jpg">
 
     <link rel="icon" href="<%- config.logo_icon %>" type="image/x-icon">
     <link rel="alternate" type="application/rss+xml" title="<%= config.title %>" href="/atom.xml">
@@ -27,7 +28,6 @@
       window.PAGE_TYPE = "<%- page.type %>"
     </script>
     <%- css('css/main') %>
-    <%- partial('partials/ga') %>
   </head>
   <body class="<%= isIndex ? 'page-index' : 'page-inner' %>">
     <div class="page">
@@ -52,7 +52,7 @@
             <path d="M115.0,115.0 C114.9,115.1 118.7,116.5 119.8,115.4 L133.7,101.6 C136.9,99.2 139.9,98.4 142.2,98.6 C133.8,88.0 127.5,74.4 143.8,58.0 C148.5,53.4 154.0,51.2 159.7,51.0 C160.3,49.4 163.2,43.6 171.4,40.1 C171.4,40.1 176.1,42.5 178.8,56.2 C183.1,58.6 187.2,61.8 190.9,65.4 C194.5,69.0 197.7,73.2 200.1,77.6 C213.8,80.2 216.3,84.9 216.3,84.9 C212.7,93.1 206.9,96.0 205.4,96.6 C205.1,102.4 203.0,107.8 198.3,112.5 C181.9,128.9 168.3,122.5 157.7,114.1 C157.9,116.9 156.7,120.9 152.7,124.9 L141.0,136.5 C139.8,137.7 141.6,141.9 141.8,141.8 Z" fill="currentColor" class="octo-body"></path>
           </svg>
         </a>
-        <style>.github-corner:hover .octo-arm{animation:octocat-wave 560ms ease-in-out}@keyframes octocat-wave{0%,100%{transform:rotate(0)}20%,60%{transform:rotate(-25deg)}40%,80%{transform:rotate(10deg)}}@media (max-width:500px){.github-corner:hover .octo-arm{animation:none}.github-corner .octo-arm{animation:octocat-wave 560ms ease-in-out}}</style>
+        <style></style>
       </header>
 
       <main class="MainContent js-MainContent" id="main">
@@ -63,12 +63,13 @@
         <% } %>
       </main>
 
+      <%- partial('partials/ga') %>
+
       <% if (!isIndex) { %>
         <script src="/js/smooth-scroll.min.js"></script>
       <% } %>
       <script src="/js/common.js"></script>
 
-
       <!-- Twitter follow button script -->
       <script>!function(d,s,id){var js,fjs=d.getElementsByTagName(s)[0],p=/^http:/.test(d.location)?'http':'https';if(!d.getElementById(id)){js=d.createElement(s);js.id=id;js.src=p+'://platform.twitter.com/widgets.js';fjs.parentNode.insertBefore(js,fjs);}}(document, 'script', 'twitter-wjs');</script>
 

+ 6 - 0
website/themes/uppy/source/css/_common.scss

@@ -340,6 +340,12 @@ a.button {
   }
 }
 
+/**
+* GitHub corner
+*/
+
+.github-corner:hover .octo-arm{animation:octocat-wave 560ms ease-in-out}@keyframes octocat-wave{0%,100%{transform:rotate(0)}20%,60%{transform:rotate(-25deg)}40%,80%{transform:rotate(10deg)}}@media (max-width:500px){.github-corner:hover .octo-arm{animation:none}.github-corner .octo-arm{animation:octocat-wave 560ms ease-in-out}}
+
 /**
 * BuildBadge
 */