Kaynağa Gözat

fix:logs and rm unused codes in CacheEmbedding (#8409)

HowardChan 7 ay önce
ebeveyn
işleme
0123498452
1 değiştirilmiş dosya ile 4 ekleme ve 7 silme
  1. 4 7
      api/core/embedding/cached_embedding.py

+ 4 - 7
api/core/embedding/cached_embedding.py

@@ -65,7 +65,7 @@ class CacheEmbedding(Embeddings):
                         except IntegrityError:
                         except IntegrityError:
                             db.session.rollback()
                             db.session.rollback()
                         except Exception as e:
                         except Exception as e:
-                            logging.exception("Failed transform embedding: ", e)
+                            logging.exception("Failed transform embedding: %s", e)
                 cache_embeddings = []
                 cache_embeddings = []
                 try:
                 try:
                     for i, embedding in zip(embedding_queue_indices, embedding_queue_embeddings):
                     for i, embedding in zip(embedding_queue_indices, embedding_queue_embeddings):
@@ -85,7 +85,7 @@ class CacheEmbedding(Embeddings):
                     db.session.rollback()
                     db.session.rollback()
             except Exception as ex:
             except Exception as ex:
                 db.session.rollback()
                 db.session.rollback()
-                logger.error("Failed to embed documents: ", ex)
+                logger.error("Failed to embed documents: %s", ex)
                 raise ex
                 raise ex
 
 
         return text_embeddings
         return text_embeddings
@@ -116,10 +116,7 @@ class CacheEmbedding(Embeddings):
             # Transform to string
             # Transform to string
             encoded_str = encoded_vector.decode("utf-8")
             encoded_str = encoded_vector.decode("utf-8")
             redis_client.setex(embedding_cache_key, 600, encoded_str)
             redis_client.setex(embedding_cache_key, 600, encoded_str)
-
-        except IntegrityError:
-            db.session.rollback()
-        except:
-            logging.exception("Failed to add embedding to redis")
+        except Exception as ex:
+            logging.exception("Failed to add embedding to redis %s", ex)
 
 
         return embedding_results
         return embedding_results